*: add a tidb system variable tidb_hash_join_concurrency #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Apr 9, 2018
sessionctx/variable/tidb_vars.go
Outdated
| @@ -138,6 +100,47 @@ const ( | |||
| TiDBEnableStreaming = "tidb_enable_streaming" | |||
| ) | |||
|
|
|||
| // TiDB session and global system variable names. | |||
|
/run-all-tests |
zz-jason
reviewed
Apr 9, 2018
sessionctx/variable/session.go
Outdated
| @@ -406,6 +410,15 @@ func (s *SessionVars) GetStatusFlag(flag uint16) bool { | |||
| return s.Status&flag > 0 | |||
| } | |||
|
|
|||
| // GetHashJoinConcurrency gets the value of SessionVars.HashJoinConcurrency. | |||
| func (s *SessionVars) GetHashJoinConcurrency() uint { | |||
There was a problem hiding this comment.
can we remove this func and initialize HashJoinConcurrency in other places, thus we can use HashJoinConcurrency like other session variables ?
|
Please resolve the conflicts and fix CI. |
Conflicts: sessionctx/variable/tidb_vars.go
|
/run-integration-common-test |
XuHuaiyu
changed the title
|
/run-integration-common-test tidb-test=pr/496 |
|
/run-integration-common-test tidb-test=pr/496 tidb-private-test=pr/8 |
|
/run-all-tests tidb-test=pr/496 tidb-private-test=pr/8 |
|
/run-integration-common-test tidb-test=pr/496 tidb-private-test=pr/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a tidb system variable called tidb_hash_join_concurrency,
thus we can change the value of hash join concurrency without restarting the tidb server.
PTAL @zz-jason @winoros